Open
Conversation
Contributor
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
4 tasks
gonidelis
force-pushed
the
merge_sort_env
branch
from
4e01064 to
a163f9d
Compare
Contributor
🥳 CI Workflow Results🟩 Finished in 1h 17m: Pass: 100%/249 | Total: 3d 07h | Max: 52m 40s | Hits: 95%/156447See results here. |
cub/cub/device/device_merge_sort.cuh
Outdated
Comment on lines
+303
to
+308
| using determinism_t = | ||
| ::cuda::std::execution::__query_result_or_t<requirements_t, | ||
| ::cuda::execution::determinism::__get_determinism_t, | ||
| ::cuda::execution::determinism::run_to_run_t>; | ||
| static_assert(!::cuda::std::is_same_v<determinism_t, ::cuda::execution::determinism::gpu_to_gpu_t>, | ||
| "gpu_to_gpu determinism is not supported for unstable sort. Use StableSortPairs instead."); |
Contributor
There was a problem hiding this comment.
Note: I need to figure out what kind of determinism we provide. The merge sort implementation is stable according to the docs, so it should provide gpu to gpu determinism. If you want to steer users away from SortPairs to StableSortPairs, if they need stabililty, that's fine. But even an unstable algorithm can be gpu_to_gpu deterministic.
Member
Author
|
After long discussion with @bernhardmgruber we decided not to specify any deterministic guarantees for |
gonidelis
force-pushed
the
merge_sort_env
branch
from
a163f9d to
40e339a
Compare
gonidelis
requested review from
NaderAlAwar,
bernhardmgruber and
srinivasyadav18
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #7544
Merge sort is inherently stable, so bothSortPairsandStableSortPairsnaturally satisfyrun_to_rundeterminism.ForStableSort*algorithms we guaranteegpu_to_gpubecause stability is part of its API contract.No refs to determinism were decided to be made